Skip to content

Adds first draft of MUtI page to link to project domain#35

Open
charlottebrf wants to merge 14 commits intomasterfrom
ministers/mvp
Open

Adds first draft of MUtI page to link to project domain#35
charlottebrf wants to merge 14 commits intomasterfrom
ministers/mvp

Conversation

@charlottebrf
Copy link
Member

@charlottebrf charlottebrf commented Jan 7, 2017 •
edited
Loading

I'm having some issues installing Jekyll, so can't see how this is looking on my local host at the moment. (See screenshot of Jekyll Ruby gem install fail).

Some to do's to improve this first version:

  1. Improvements with Bootstrap to add this project to the right side of the Nav Bar
  2. Improve layout - bit more visually appealing
  3. Add photos of team & accelerator meetups

screen shot 2017-01-07 at 14 34 10

elischutze
elischutze reviewed Jan 7, 2017
View reviewed changes
_layouts/ministers_under_the_influence Outdated
Copy link
Member

@elischutze elischutze Jan 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after period few months.See

_layouts/ministers_under_the_influence Outdated
Copy link
Member

@elischutze elischutze Jan 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are meeting with maybe? 🤔

@charlottebrf charlottebrf mentioned this pull request Jan 7, 2017
Merged
eddiejaoude
eddiejaoude reviewed Jan 9, 2017
View reviewed changes
_layouts/ministers_under_the_influence.html Outdated
Copy link
Contributor

@eddiejaoude eddiejaoude Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<p> tags are not needed here

eddiejaoude
eddiejaoude reviewed Jan 9, 2017
View reviewed changes
_layouts/ministers_under_the_influence.html Outdated
Copy link
Contributor

@eddiejaoude eddiejaoude Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is not correct

eddiejaoude
eddiejaoude reviewed Jan 9, 2017
View reviewed changes
_layouts/ministers_under_the_influence.html Outdated
Copy link
Contributor

@eddiejaoude eddiejaoude Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does INCOMPLETE go? holding page? or better to disable the link to avoid confusion?

@eddiejaoude
Copy link
Contributor

eddiejaoude commented Jan 9, 2017

How do we navigate to this page?

@charlottebrf
Copy link
Member Author

charlottebrf commented Jan 9, 2017 •
edited
Loading

This is looking a bit better but still quite sparse. Some ways it could be improved:

  1. Add Team & Contributors to a container so list is displayed across the page rather than just down the page.

  2. Make the font size bigger. However, this would have to be changed across entire site

  3. Decrease size of the banner image in the header, currently very large taking up lots of space.

  4. Include pictures from HB Accelerator meetups of team, it's a bit of a dull page right now.

@eddiejaoude @elischutze any suggestions welcomed!
screen shot 2017-01-09 at 22 49 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elischutze elischutze elischutze approved these changes

+1 more reviewer

@eddiejaoude eddiejaoude eddiejaoude left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@eddiejaoude eddiejaoude

@elischutze elischutze

Labels

incomplete

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charlottebrf @eddiejaoude @elischutze

Comments